OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
89 stars 70 forks source link

Use Echodata `Platform` and `Beam_group1` Variables to Compute Depth for EK60/EK80 #1319

Open ctuguinay opened 1 month ago

ctuguinay commented 1 month ago

Based on Emilio's #1205 PR. Addresses #790 and #1152.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.21%. Comparing base (9f56124) to head (fee0c96). Report is 119 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1319 +/- ## =========================================== + Coverage 83.52% 94.21% +10.69% =========================================== Files 64 4 -60 Lines 5686 242 -5444 =========================================== - Hits 4749 228 -4521 + Misses 937 14 -923 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1319/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `94.21% <100.00%> (+10.69%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 1 month ago

@leewujung This should be ready for review. The only changes I made from the last time we talked were how to deal with choosing Beam_group1 vs Beam_group2, and interpolating transducer depth time2 to ping_time if and only if they are not equal.

ctuguinay commented 11 hours ago

@leewujung Thanks for the review! This should be ready to review again