search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 73 forks source link

Investigate Echo Range Scaling with Both Beam and Platform Angles (at the same time) #1324

Open ctuguinay opened 4 months ago

ctuguinay commented 4 months ago

From discussion of #1319 with @leewujung, I've limited the add_depth code to work with either Platform group angles or Beam group angles, but not both. The angles are currently being used to compute an echo range scaling factor, i.e., how much we should scale the original echo range values based on the total tilt of the transducer with respect to the z-axis.

The problem with incorporating both is that we do not know if the Platform group angles and the Beam group angles (at least for EK60/EK80) are coupled or decoupled, and the state of coupling will determine whether or not we can use them in conjunction with each other. Another way to phrase this is whether we can apply the Beam group angle rotations on top of the Platform group angle rotations, and vice versa. Currently, I am of the opinion that whether we can do these operations and receive valid results will be very dependent on the setup of the instruments involved in getting these angle measurements.

ctuguinay commented 4 months ago

Note to self, would need to find data with non-NaN/non-0 Beam and Platform Angle data. When looking at the data test suite right now, I have yet to find a RAW file that has this property. Usually, it is just one of the groups having valid angle data. I'll leave this issue without a milestone and wait until a contributor has found a RAW file that has this property or a user has made a request for both groups' angle data to be used in echo_range_scaling.