Closed leewujung closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.51%. Comparing base (
9f56124
) to head (985a3b1
). Report is 118 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@leewujung This should be ready for review. I added a test and dropped time1
after the interpolation and ffill.
This PR fixes various problems discovered in applying
compute_Sv
on combinedEchoData
object:ping_time
extends beyond the end oftime1
for the environmental paramsbottleneck
as dependency as it is needed for xr.DataArray.ffillTODO: