OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 73 forks source link

Fix problems in applying `compute_Sv` on combined `EchoData` object #1328

Closed leewujung closed 3 months ago

leewujung commented 4 months ago

This PR fixes various problems discovered in applying compute_Sv on combined EchoData object:

TODO:

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.51%. Comparing base (9f56124) to head (985a3b1). Report is 118 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1328 +/- ## ========================================== + Coverage 83.52% 89.51% +5.98% ========================================== Files 64 11 -53 Lines 5686 1001 -4685 ========================================== - Hits 4749 896 -3853 + Misses 937 105 -832 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1328/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `89.51% <100.00%> (+5.98%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 3 months ago

@leewujung This should be ready for review. I added a test and dropped time1 after the interpolation and ffill.