Closed ctuguinay closed 6 days ago
Attention: Patch coverage is 89.47368%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 93.42%. Comparing base (
9f56124
) to head (aee9e12
). Report is 95 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
echopype/mask/api.py | 89.47% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@leewujung This should be ready for review. It addresses the problem in that freq-diff and apply mask MVBS workflow that Soham showed the other day.
@leewujung Thanks for the review!
So I suggest we do the following:
put these few lines directly in
apply_mask
# Validate the source_ds type or path (if it is provided) source_ds, file_type = validate_source(source_ds, storage_options_ds) if isinstance(source_ds, str): # open up Dataset using source_ds path source_ds = xr.open_dataset(source_ds, engine=file_type, chunks={}, **storage_options_ds)
- rename the function to be
_check_mask_dim_alignment
for the new code you added
Yeah I agree, it was a bit much in a single function. I'll make these changes (once I get good WiFi again)
Addresses #1330