OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
99 stars 76 forks source link

Provide vessel speed over ground when available #1346

Open gavinmacaulay opened 5 months ago

gavinmacaulay commented 5 months ago

I miss the speed_over_ground variable when reading in Simrad EK data files - is it somewhere? A search of the echopype code didn't show up any code dealing with extracting speed from NMEA data, so perhaps not?

The sonar-netcf4 convention has 'speed_over_ground' as a variable under Platform (v1) or under Platform/NMEA (v2).

leewujung commented 2 weeks ago

@NikiDab : For sound_over_ground, you can try set a breakpoint after https://github.com/OSOceanAcoustics/echopype/blob/2813a25437fd9985411c96dc0c3cc8b7d223dc05/echopype/convert/api.py#L472 (parser.parse_raw() actually parses the data) This way you can inspect what is in the parsed data object (some attributes are in a dict of dict of dict structure, so not the easiest to work with -- this came from PyEcholab and we may want to restructure down the line if there’s extra time).

For EK80 data, the NMEA data are parsed into the parser.nmea attribute https://github.com/OSOceanAcoustics/echopype/blob/2813a25437fd9985411c96dc0c3cc8b7d223dc05/echopype/convert/parse_base.py#L64 You can see if this variable is parsed in there in the test files we have. If not, you may have to trace back to the parser code to see why that is not parsed properly. It could also be something that Simrad added more recently (the .raw data format still gets updated regularly), and our test files may not include that.

@gavinmacaulay: could you provide a test file (ideally <5 MB, the smaller the better) so that @NikiDab could take a stab at this?

Thanks both!

gavinmacaulay commented 2 weeks ago

I don't have example files that small. However, a 35MB one is a available here: https://aqualyd-my.sharepoint.com/:i:/g/personal/enquiries_aqualyd_nz/EdZq6IzuN8hNpIEpnh0xhv4BaJLTR0l4nLyxfTbIgSZ0Xw?e=exdtWN. The link will be valid for 1 week, so take a copy if you need.

NikiDab commented 2 weeks ago

Thank you. I will download the file.

-Niki

On Tue, Nov 12, 2024 at 9:00 PM Gavin Macaulay @.***> wrote:

I don't have example files that small. However, a 35MB one is a available here: https://aqualyd-my.sharepoint.com/:i:/g/personal/enquiries_aqualyd_nz/EdZq6IzuN8hNpIEpnh0xhv4BaJLTR0l4nLyxfTbIgSZ0Xw?e=exdtWN. The link will be valid for 1 week, so take a copy if you need.

— Reply to this email directly, view it on GitHub https://github.com/OSOceanAcoustics/echopype/issues/1346#issuecomment-2472170750, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMY32VB4WWOB7NAFS27O5WD2AKXDRAVCNFSM6AAAAABJXZICA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZSGE3TANZVGA . You are receiving this because you were mentioned.Message ID: @.***>