OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
89 stars 70 forks source link

Update docs for visualization #1347

Closed leewujung closed 1 week ago

leewujung commented 1 week ago

This addresses the documentation part of #1276.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

review-notebook-app[bot] commented 1 week ago

View / edit / reply to this conversation on ReviewNB

ctuguinay commented on 2024-06-24T23:43:14Z ----------------------------------------------------------------

Not sure how to make suggestions in reviewnb:

However, but careful about these rainbow-color type of colormaps, because our perception of different colors can often skews what we think is the most prominent features in an echogram.

To:

However, be careful with rainbow colormaps because our perception of different colors can often skew what we think is the most prominent features in an echogram.

leewujung commented 1 week ago

Thanks @ctuguinay! Now it's my turn needing another review 😅