search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
89 stars 70 forks source link

Coding: `channel_mode` dtype from `float16` to `float32` #1350

Closed ctuguinay closed 3 days ago

ctuguinay commented 3 days ago

Fixes #1348: NetCDF doesn't accept np.float16 and only accepts np.float32 and np.float64.

ctuguinay commented 3 days ago

The tests that fail here are unrelated to the issue that this addresses and are instead related to https://github.com/OSOceanAcoustics/echopype/issues/1332.

leewujung commented 3 days ago

The failed tests here seems to be from validate_source and not the noise removal stuff in #1332?

ctuguinay commented 3 days ago

@leewujung Oh those are the xfailures. 2 XFailures and 2 Failed. The 2 Failed are related to background noise removal.

leewujung commented 3 days ago

@ctuguinay : Oh you're right I misread it! I blame it to turbulence!