OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

hotfix: Temporarily skip datagrams generated by EC150 #1357

Closed leewujung closed 2 months ago

leewujung commented 2 months ago

This PR includes changes to ParseEK to skip reading and saving datagrams generated by EC150 ADCP.

We can actually parse the echosounder-equivalent data fine, but we still need 2 other pieces to carry it to the next stage, so this is a "hotfix" to just skip these datagrams for now. The pieces we need are:

This PR still needs:

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (9f56124) to head (b34f7bb). Report is 123 commits behind head on main.

Files Patch % Lines
echopype/convert/parse_base.py 90.90% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1357 +/- ## ========================================== - Coverage 83.52% 78.87% -4.65% ========================================== Files 64 16 -48 Lines 5686 2708 -2978 ========================================== - Hits 4749 2136 -2613 + Misses 937 572 -365 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `78.87% <90.90%> (-4.65%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.