Closed leewujung closed 2 months ago
Attention: Patch coverage is 90.90909%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 78.87%. Comparing base (
9f56124
) to head (b34f7bb
). Report is 123 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
echopype/convert/parse_base.py | 90.90% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR includes changes to
ParseEK
to skip reading and saving datagrams generated by EC150 ADCP.We can actually parse the echosounder-equivalent data fine, but we still need 2 other pieces to carry it to the next stage, so this is a "hotfix" to just skip these datagrams for now. The pieces we need are:
Beam_group3
or with the previousBeam_group1/2
?This PR still needs: