search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

Use latest MRU parser version; `ep.consolidate.add_location` can be based off Datagram Type #1359

Closed ctuguinay closed 2 months ago

ctuguinay commented 2 months ago

The latest EK MRU parser code from Rick Towler can be found at https://github.com/noaa-afsc-mace/pyEcholab/blob/2314b374ffe99f7c3e3c920ef3f9a240e7715789/echolab2/instruments/util/simrad_parsers.py#L569C1-L708C61. Includes latitude and longitude field values, and we now parse this.

Setting of platform groups will now set (lat/lon)_(idx/mru/nme). Additionally, ep.consolidate.add_location will also be based off of the datagram type passed in (i.e IDX/MRU/NME).

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.47899% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (9f56124) to head (c706490). Report is 129 commits behind head on main.

Files Patch % Lines
echopype/convert/utils/ek_raw_parsers.py 71.42% 2 Missing :warning:
echopype/echodata/combine.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1359 +/- ## =========================================== - Coverage 83.52% 63.28% -20.24% =========================================== Files 64 34 -30 Lines 5686 4135 -1551 =========================================== - Hits 4749 2617 -2132 - Misses 937 1518 +581 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `63.28% <97.47%> (-20.24%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 2 months ago

@leewujung This should be ready for review

ctuguinay commented 2 months ago

@leewujung Thanks for the review! This should be ready for review. I just had a few comments