search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

`.drop` to `.drop_vars` #1364

Closed ctuguinay closed 2 months ago

ctuguinay commented 2 months ago

Fixes part of #1309

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (9f56124) to head (1f02cfe). Report is 131 commits behind head on main.

Files Patch % Lines
echopype/calibrate/range.py 33.33% 2 Missing :warning:
echopype/calibrate/calibrate_ek.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1364 +/- ## ========================================== + Coverage 83.52% 89.52% +6.00% ========================================== Files 64 11 -53 Lines 5686 1002 -4684 ========================================== - Hits 4749 897 -3852 + Misses 937 105 -832 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1364/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `89.52% <50.00%> (+6.00%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 2 months ago

@leewujung This is ready to review. It fixes a part of #1309.