search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
99 stars 76 forks source link

Remove min max attributes for `compute_MVBS` #1380

Closed ctuguinay closed 2 months ago

ctuguinay commented 3 months ago

Addresses #1378

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.92%. Comparing base (9f56124) to head (aed7143). Report is 136 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1380 +/- ## =========================================== + Coverage 83.52% 96.92% +13.40% =========================================== Files 64 3 -61 Lines 5686 195 -5491 =========================================== - Hits 4749 189 -4560 + Misses 937 6 -931 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `96.92% <ø> (+13.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 3 months ago

@leewujung Just removed those few lines. This should be ready for a review.

Edit: Min/Max were actually eagerly calculated twice in the MVBS operation!

ctuguinay commented 2 months ago

@leewujung Thanks for the review! I'll add an issue for the standalone function