search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
99 stars 76 forks source link

EK60 Conversion: Drop channels that don't have power data #1383

Closed ctuguinay closed 2 months ago

ctuguinay commented 3 months ago

Solves the channel-specific missing environment variable issue mentioned in #1374.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.22%. Comparing base (9f56124) to head (6cc8dda). Report is 136 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1383 +/- ## ========================================== - Coverage 83.52% 80.22% -3.31% ========================================== Files 64 18 -46 Lines 5686 3089 -2597 ========================================== - Hits 4749 2478 -2271 + Misses 937 611 -326 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1383/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `80.22% <100.00%> (-3.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 3 months ago

@leewujung This should be ready for review