search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
98 stars 73 forks source link

Consider overlap/divergence in EK60 and EK80 parsing #155

Closed leewujung closed 3 years ago

leewujung commented 4 years ago

EK60 and EK80 raw file structures are very similar but have important differences here and there, especially since that EK80 setting is more flexible (or users tend to use variable settings), so we've been doing a lot of patches to make sure files from different sources would convert successfully.

As more testing for the convert and model (soon to be changed to process) modules are now in place, at some point in the near future let's take a step back to consider combining and refactoring some of the methods to make the partially overlapping structure easier to maintain in the future.

Related issues/PRs are: #148 , #154

leewujung commented 3 years ago

This can now be closed as the new convert module covers the refactoring mentioned in this issue.