OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
98 stars 73 forks source link

Handle parameter changes across multiple files when combining for EK60/EK80 #180

Closed ngkavin closed 3 years ago

ngkavin commented 4 years ago

When combining, parameters like sound speed and seawater absorption are taken only from the first raw file, but these values can change between files. There does not seem to be a practical way of saving, for example, multiple sound speed values as there is no dimension along which to concatenate these values. So a warning should be given and the first value will be used in the combination.

Then proceed with combination.

leewujung commented 3 years ago

This issue is outdated since the code has had substantial changes and the encoding of env parameters are different for different instruments. I'll close this now and have duplicated my comments below to the new issue #364 that focuses on combining multiple EchoData objects.

Notes: