search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

Adding support for ES80 data #269

Closed DLWangSan closed 2 years ago

DLWangSan commented 3 years ago

Hello, I used echopype to analyze the EK80 data on board, and the workload is greatly reduced! Now that we have ES80 sonar data, I wonder if subsequent versions of echopype will add support for ES80 devices?

The following is some data of ES80 sonar equipment：

https://drive.google.com/drive/folders/1j7GKaE-WpfAhrD3MHQ4PXe1yHo3PaFIb

Thank you !

leewujung commented 3 years ago

@DLWangSan : glad that you found echopype helping your work! :)

It'll be awesome to include ES80 support in echopype, though at the moment we are short on hands to add support for ES80.

Would you be interested in helping adding the support for ES80? A quick googling led to this doc that explains the format and it seems reasonable. I can help with getting things into the standardized format.

DLWangSan commented 3 years ago

thank you very much! If I can help, I would be happy to contribute a little to echopype

leewujung commented 3 years ago

Great! If you are able to get started on a parser to read in the data, I can set up a branch that you could PR to. Just let me know.

gavinmacaulay commented 3 years ago

As I understand it, the file format of the ES80 is identical to the EK80 (with a few trivial metadata changes).

leewujung commented 3 years ago

@gavinmacaulay : that's great! Do you have some test files that we could try on?

gavinmacaulay commented 3 years ago

I have ES80 files that I can offer. Where should I put them? I also have ES70 files (same format as the ES/ER60 files) if desired.

To go with these, I have a nearly ready PR that makes the fairly trivial changes necessary for echopype to read ES70 files (ES80 will be just as trivial).

leewujung commented 3 years ago

Fantastic! I just sent you an invitation to a Google Drive folder we use to store test data files at the moment (as documented here).

Looking forward to the PR!! 😃 We can add tests to run through your files once they are in the folder, like what we have for all the other formats.

gavinmacaulay commented 3 years ago

echopype reads ES80 files without any changes needed if those files only contain data from WBT transceivers (the files are near identical to those produced by the EK80 software). But ES80 (and EK80) files can also contain data from a GPT transceiver. Currently, echopype fails to read those files. See #409 for some more details.

leewujung commented 2 years ago

Closing this so that ES80-related issues are consolidated, in #497.