Error when trying to calibrate an EK80 file with both CW (power) and BB (complex) channels

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis

https://echopype.readthedocs.io/

Apache License 2.0

95 stars 73 forks source link

Error when trying to calibrate an EK80 file with both CW (power) and BB (complex) channels #310

Closed ngkavin closed 3 years ago

ngkavin commented 3 years ago

Calibration fails for the test file Summer2018--D20180905-T033113.raw when the calibration parameters are being retrieved. The error message is: ValueError: operands could not be broadcast together with shapes (5,5) (3,1).

Specifying the waveform_mode and the encode_mode still resulted in the error.

leewujung commented 3 years ago

This is due to the fact that _get_vend_cal_params_power should not be called in the BB case, and the factors 'sa_correction', 'gain_correction' are not used for BB calibration. This requires some refactoring and let's try to get this in in the upcoming minor releases.

imranmaj commented 3 years ago

Fixed in #400