OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

Band-averaged broadband calibration needs to use actual gain from file #384

Closed leewujung closed 2 years ago

leewujung commented 3 years ago

This is most likely a leftover while we developing the code, that the gain for band-averaged broadband calibration (for pulse compressed outputs) for EK80 now actually hard codes the gain to be 27, instead of pulling it from the data file. There is also a TODO for generating the gain at the center frequency in the actual transmit signal band.

Code section: https://github.com/OSOceanAcoustics/echopype/blob/master/echopype/calibrate/calibrate_ek.py#L526-L527

Let's get this fixed very soon.

leewujung commented 2 years ago

This is addressed in #477 .