Closed leewujung closed 2 years ago
I think the solution may be speeding up the test and like you said in #553, run all tests every time. We have not utilized the parallel testing... I know there were some issues there, but I'll get back to it.
From @lsetiawan in #601:
Thinking about it, I wonder if we can add like specific connected modules that should also be run for that module if it uses functions from those connected modules. Does that make sense? 😆 This way, we can have an "extensive" test without having to run the whole test!
Noted down some 3.9 and 3.10 test failures for investigation: https://github.com/OSOceanAcoustics/echopype/actions/runs/2153214186/attempts/1 Similar test failures have occurred a few times in the v0.5.6-->v0.6.0 dev period.
Let's close this one and open a new issue on whether we want to switch to always running all tests regardless of which files are changed in a PR.
Seems like we can close this now that @lsetiawan has put in quite a bit of work to make the tests more robust?
Sounds good to me. Thanks
In our current testing setup, when PR to
dev
the test is only run on the modified module and not on the downstream tests. The entire set of tests are run when the PR is merged todev
(ormain
). So what we have right now is a little brittle even though bugs would be caught and fixed eventually. It'll be good for us to rethink how we can upgrade this and still with reasonable the CI running time.Below are conversions from discussions re testing in #547:
@lsetiawan :
@leewujung :
Also related on the current status: @lsetiawan :
@emiliom :