OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

Populate or fix sonar_software_name and sonar_model for EK60 and maybe other instruments #571

Closed emiliom closed 1 year ago

emiliom commented 2 years ago

(Originally discussed in https://github.com/OSOceanAcoustics/echopype/issues/210#issuecomment-822642399)

For EK60:

We haven't examined these closely (AFAIK) for EK80, AZFP or other instruments.

These attributes could be examined in parallel with Sonar/sonar_serial_number, #212

emiliom commented 2 years ago

I don't think I'm the right person for this issue, since I'm not well versed with the raw datagrams.

leewujung commented 2 years ago

I assigned both you and me, because I need to consult you on the naming choice of attributes that we will need to create to take care of the things that may not be in the convention.

emiliom commented 2 years ago

Ah! Thanks for that clarification. I didn't see that.

emiliom commented 2 years ago

Note: ER60 is in fact the name of the Simrad software. eg, see https://support.echoview.com/WebHelp/Reference/File_formats/Simrad_data_files.htm

leewujung commented 2 years ago

We decided to review the detailed content of variables after v0.6.0 now that we have the disruptive type of changes in for v0.6.0.

emiliom commented 1 year ago

sonar_model was already addressed for v0.6.0. See https://github.com/OSOceanAcoustics/echopype/issues/681#issuecomment-1339962902.

In this issue, the only remaining topic is sonar_software_name. It may be more convenient to address that question in #681 and close this issue.