OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

Add option in `consolidate.add_depth` to use variables already in EchoData #790

Closed leewujung closed 2 months ago

leewujung commented 2 years ago

Right now consolidate.add_depth accepts only scalar inputs for input arguments depth_offset and tilt. However, these two variables can conveniently be DataArray with a time dimension. Or we may want to use the variables already stored in the EchoData object from which the Sv is derived from.

Relevant variables in the EchoData object are water_depth, vertical_offset, and tilt (AZFP only) all in the platform group.

This is required for the glider echopype-example notebook to plot the true depth.

Tasks

emiliom commented 1 year ago

@leewujung: AZFP data come with two tilt variables, tilt_x and tilt_y. I haven't been able to find unambiguous definitions of these two variables in ASL / AZFP documentation. What are the orientations of x and y?

consolidate.add_depth has a tilt argument. For AZFP data, how do we calculate tilt from tilt_x and tilt_y? Would the calculation always be unambiguous?

emiliom commented 1 year ago

I'm in touch with Steve and Julek (ASL) and have made progress with understanding tilt_x and tilt_y.

emiliom commented 1 year ago

Refer to #1051 for related discussions.