OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
94 stars 73 forks source link

Remove remnant unused "ALL" param in parser object #857

Closed leewujung closed 9 months ago

leewujung commented 1 year ago

We decided (and implemented) a few releases ago that we will NOT allow selective parsing of only a subset of EK60/EK80 datagrams. However the old selector self.data_Type = "ALL" is still present in the code and causing confusion. Let's remove it.

emiliom commented 1 year ago

Is this as simple as removing these two blocks? (plus related small edits to inline comments)

https://github.com/OSOceanAcoustics/echopype/blob/f8082cac32bfbee2b21c62d266507491d221182d/echopype/convert/parse_ek80.py#L15-L16

https://github.com/OSOceanAcoustics/echopype/blob/f8082cac32bfbee2b21c62d266507491d221182d/echopype/convert/parse_ek60.py#L12-L13

leewujung commented 1 year ago

I am not sure, but it likely involves checking some functions that used ALL as a param. I think those were meant to try to selectively parse only some datagram types. Not sure if the mechanisms were entirely removed.

emiliom commented 1 year ago

Ah, ok. I did a quick search for the string "ALL" (upper case) and found usage cases. I'll go through them.