OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

Incorrect insertion of meta_source_filenames during conversion for EK80, ES70, ES80, EA640 #907

Closed emiliom closed 1 year ago

emiliom commented 1 year ago

PR #814 introduced a small bug where the Provenance variable meta_source_filenames is being incorrectly inserted during file conversion (open_raw) for EK80, ES70, ES80 and EA640. Currently that attribute is needed only with the AZFP sensor. An empty meta_source_filenames variable is being inserted for these sensor models due to a bug in prov.source_files_vars. This bug does not impact EK60.

AFAIK this bug is innocuous, because that variable is never used outside of AZFP.

I'll submit a fix shortly.

emiliom commented 1 year ago

Fixed in PR #908