Closed ctuguinay closed 1 year ago
Merging #110 (9d6809b) into main (cdc75c1) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 76.22% 76.28% +0.05%
==========================================
Files 13 13
Lines 408 409 +1
==========================================
+ Hits 311 312 +1
Misses 97 97
Impacted Files | Coverage Δ | |
---|---|---|
echoregions/regions2d/regions2d_parser.py | 95.65% <ø> (ø) |
|
echoregions/lines/lines_parser.py | 100.00% <100.00%> (ø) |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Clean Up Parsing TODOs
This PR addresses #109.
This small PR includes:
regions2d_parser.py
, add back .evr to file_nameregions2d_parser.py
, remove TODO forfid.readlines()
. There seem to be too many options for the number of possible values and so a counter in conjunction withfid.readlines()
would involve a (somewhat) non-repeating pattern for the counter to increase, and this would be more convoluted than just directly callingfid.readline()
multiple timeslines_parser.py
, add back .evl to file_namelines_parser.py
, replaced readline() with readlines()lines_parser.py
, added code for raising an error for evl file with too few lines