OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

Improve Testing #115

Closed ctuguinay closed 1 year ago

ctuguinay commented 1 year ago

Improve Testing

This PR addresses #58, #107, #85, #112, #113, #99, #53, #28, #120:

codecov[bot] commented 1 year ago

Codecov Report

Merging #115 (467a26a) into main (25a4518) will increase coverage by 4.42%. The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   80.21%   84.64%   +4.42%     
==========================================
  Files          13       13              
  Lines         551      534      -17     
==========================================
+ Hits          442      452      +10     
+ Misses        109       82      -27     
Files Changed Coverage Δ
echoregions/utils/api.py 76.38% <ø> (ø)
echoregions/utils/time.py 82.75% <75.00%> (-2.43%) :arrow_down:
echoregions/regions2d/regions2d.py 83.72% <80.00%> (+3.20%) :arrow_up:
echoregions/lines/lines.py 91.76% <100.00%> (+3.81%) :arrow_up:
echoregions/regions2d/regions2d_parser.py 100.00% <100.00%> (+4.34%) :arrow_up:
echoregions/utils/__init__.py 100.00% <100.00%> (ø)
echoregions/utils/io.py 67.56% <100.00%> (+22.88%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ctuguinay commented 1 year ago

Hey, could you guys take a look at this PR when you are free? @leewujung @valentina-s

Mostly fixing up tests and some cosmetic/documentation modifications. Nothing really changed with functionality.

ctuguinay commented 1 year ago

Hey @valentina-s, just addressed your comments in the most recent pushes!