search

OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

Fix bug in the `close_region` call in `Regions2D.plot` #133

Closed leewujung closed 11 months ago

leewujung commented 11 months ago

This is a small bug fix that remove the wrong reference of self.Regions2D.close_region in Regions2D.plot. self is already the Regions2D object.

leewujung commented 11 months ago

The test failures have nothing to do with the one line change I made in this PR.

Looks like there's something different between regionmask 0.10.0 and 0.11.0. The last merge to main was run with regionmask=0.10.0, and this failure is with regionmask=0.11.0. And, regionmask=0.11.0 as just released 2 days ago!