OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

`Regions2D.mask` should allow `region_ids=None` as default #135

Closed leewujung closed 9 months ago

leewujung commented 11 months ago

Right now Regions2D.mask requires region_ids: List as input without a default value.

I think we can add None as default so that Regions2D.mask has the same behavior as .plot and .close_region that defaults to region_id=None and plot or close all regions in this case.

And note #134 for changing region_ids to just region_id.

This is a relatively small change, so I suggest having it in v0.1.0.

leewujung commented 9 months ago

This is addressed in #139 .