OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

Add handling of overlapping regions in `Regions2D.mask` #136

Closed leewujung closed 9 months ago

leewujung commented 11 months ago

In #87 we said we'll handle overlapping regions when it arises. I just ran into one case!

In this particular, one region is entirely within another one, and in fact the smaller one is supposed to be "hollow" within the larger one. See the brown region at ~17:00 within the large purple region.

Screenshot 2023-09-24 at 11 39 02 AM

I think we have a few choices to make here:

This is definitely not a v0.1.0 issue. I think these are more of backburners that we can pick up after v0.2.0. I think we can take care of the partially overlapping scenario first, and then see if we still need to handle the nested case.

leewujung commented 9 months ago

This is addressed in #139 by disallowing overlapping regions for 2D masks and allowing those for 3D masks.