OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

Fix 0.11.0 region mask #139

Closed ctuguinay closed 11 months ago

ctuguinay commented 11 months ago

This PR addresses #134 #135 #136:

Major Changes

Minor Changes

codecov[bot] commented 11 months ago

Codecov Report

Merging #139 (732a279) into dev (b179117) will increase coverage by 2.59%. Report is 10 commits behind head on dev. The diff coverage is 92.59%.

:exclamation: Current head 732a279 differs from pull request most recent head 2276b11. Consider uploading reports for the commit 2276b11 to get more accurate results

@@            Coverage Diff             @@
##              dev     #139      +/-   ##
==========================================
+ Coverage   84.75%   87.35%   +2.59%     
==========================================
  Files          13       13              
  Lines         538      522      -16     
==========================================
  Hits          456      456              
+ Misses         82       66      -16     
Files Coverage Δ
echoregions/core.py 100.00% <ø> (ø)
echoregions/regions2d/regions2d.py 85.45% <95.45%> (+1.50%) :arrow_up:
echoregions/utils/api.py 92.59% <89.18%> (+16.20%) :arrow_up:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ctuguinay commented 11 months ago

@leewujung This PR is ready for a re-review. It addresses all the suggestions in the comment about and all the in-line comments.