Closed ctuguinay closed 9 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
3534c97
) 87.23% compared to head (a06060a
) 87.54%. Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@leewujung, Here are some slight changes made corresponding to errors that I noticed when running echoregion functions in hake labels.
An offshoot when I was looking at the tests: seems like there is a missing assert condition in the last line of test_mask_empty_no_overlap?
Just added this assert.
Recent Changes:
@leewujung This is ready to be reviewed again.
For lines masking: Clean up how
bottom_interpolated
is constructed. Past version had unused variables. For regions2d masking: Made use of numbers instead of names in regionmask regions initialization so to work directly with the dimension region instead of having to switch coordinate names with dimension regions.Also, solved problem where echoregions version cannot be imported in the top level
__init__.py
file of the package.