search

OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

Use `**kwargs` to delegate interpolation method selection to `pandas.DataFrame.interpolate` #151

Closed leewujung closed 9 months ago

leewujung commented 10 months ago

Currently in Lines.mask the allowed interpolation schemes are hard-coded and also cannot accept the associated kwargs for spline and krogh. This can be circumvented by passing the method and the associated kwargs to pandas.DataFrame.interpolate so if anything fails it fails there.

leewujung commented 10 months ago

Also reading into the Lines.mask function some more, using kwargs will also allow passing additional arguments such as limit_area, limit_direction, etc to the pandas.DataFrame.interpolate function under the hood.

ctuguinay commented 9 months ago

Closed by #156