search

OSOceanAcoustics / echoregions

Interfacing water column sonar data with annotations and labels
https://echoregions.readthedocs.io/
Apache License 2.0
6 stars 6 forks source link

Rework Select Sonar #169

Closed ctuguinay closed 8 months ago

ctuguinay commented 10 months ago

The primary change is that the function now uses dataset/data array time variable start and end selection instead of filename time values.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.91%. Comparing base (8fecc8f) to head (e89e24f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #169 +/- ## ========================================== + Coverage 87.80% 87.91% +0.11% ========================================== Files 13 13 Lines 582 571 -11 ========================================== - Hits 511 502 -9 + Misses 71 69 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 10 months ago

@leewujung This is ready to be reviewed

ctuguinay commented 10 months ago

Codecov says 'All modified and coverable lines are covered by tests ✅', so I think this coverage difference is alright?

ctuguinay commented 8 months ago

Hey @leewujung, I added a few more checks for the gating in the test_select_sonar function. Do you think I should remove the parse_simrad_fname_time function from utils/time.py? The only place it was used was in the previous iteration of select_sonar.

leewujung commented 8 months ago

Yeah, I think that function could be removed.

ctuguinay commented 8 months ago

@leewujung Just removed it

leewujung commented 8 months ago

@ctuguinay : I pulled in all changes from main.