search

OSOceanAcoustics / echoshader

Interactive visualization of ocean sonar data
https://echoshader.readthedocs.io
MIT License
9 stars 8 forks source link

Feature stats #128

Closed ldr426 closed 12 months ago

ldr426 commented 1 year ago

This is a draft PR about stats part in echoshader. Modification, demo showcase and docstring will be added later.

  1. For get_stats.py : plot_side_hist is reserved and opsional functions, not related to core business. plot_hist and plot_table return relative holoview object based on MVBS parameter.
  2. For ehocgram.py:
    • histogram plots histogram with two modes optional, overlay and layout. There are 2 control widgets are bond to this function: bin_size_input and overlay_layout_toggle to tune bins and toggle mode. The plot is updated automatically without update button.
    • table plots stats info with N+1 columns (sum + n channels). The plot is also updated automatically without update button
review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

leewujung commented 1 year ago

Hey @ldr426 : I changed the PR target to dev (you originally had it targeting main) but it did not help with pulling the commits that you had from #122. I've just merged #122 to dev. Please merge the new dev into your branch feature-stats and then create a new PR, and hopefully we can see the clean commit history there. Make sure to resolve the conflicts and pre-commit error in the new PR. Thanks!