search

OSOceanAcoustics / echoshader

Interactive visualization of ocean sonar data
https://echoshader.readthedocs.io
MIT License
9 stars 8 forks source link

Disassociate echogram and map + curtain functionalities #129

Closed leewujung closed 1 year ago

leewujung commented 1 year ago

From https://github.com/OSOceanAcoustics/echoshader/pull/122#pullrequestreview-1528971852

  • the map and curtain functionalities should not be in the Echogram class; they should remain accessible through the accessor approach though -- this will require careful design work
  • many of the param.depends components seem can be moved out of the methods so that they can be specified by the users (and we need to supply clear documentations for how they should be used)
ldr426 commented 1 year ago

Has been solved in https://github.com/OSOceanAcoustics/echoshader/pull/131