Closed ldr426 closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@ldr426 Could you reorganize the repo to remove the new_version_3
folder so that it is ready for merging following the standard package structure.
|-- echoshader
|-- old_versions_folders (we can remove them once we settle )
|-- ...
|-- core.py
|-- echogram.py
|-- xyz.py (other scripts)
|-- tests (a folder containing test scripts corresponding to each module)
|-- test_core.py
|-- test_echogram.py
|-- test_xyz.py
|-- notebooks
Hey @valentina-s, Thanks! Also need to update requirement.txt
and add env creating command as I told you before:
mamba create -n echoshader -c pyviz -c conda-forge hvplot geoviews pyvista ipykernel
This related to https://github.com/OSOceanAcoustics/echoshader/issues/120
Also a few other notes:
Hey @valentina-s, Thanks! Also need to update
requirement.txt
and add env creating command as I told you before:mamba create -n echoshader -c pyviz -c conda-forge echopype hvplot geoviews pyvista ipykernel
This related to #120
So if the assumption is that people have created the MVBS_Sv dataset, they would not need echopype any more.
@ldr426 I see that you have done the bidirectional logic. It is great that it worked out! Could you reorganize the folder structure to remove the new_version_3 folder, so that this PR is ready for merging. We should finalize this version before doing other things, those can be done as separate issues and PRs.
@ldr426 I managed the import and fiddled with several panel configurations of the widgets. Some of the interactive linking did not work for me, although one direction worked. I can test more with the new notebooks. For now just make the current one properly import the package. And change the PR from Draft to ready for review, so I can merge it.
This pull request aims to introduce the final version of the Refactoring for the Echoshader project. This PR aims to implements all functionalities with relative control widgets, dynamical box, and linkage to enhance the project's capabilities and user experience.
The PR includes four key files that provide essential functionalities:
core.py
: This class acts as a central handler for managing echograms, maps, and statistics. It serves as a superstructure with interfaces for plotting, control widgets, bounds, and links.echogram.py
: This file contains functions related to echograms, including single frequency echograms and tricolor echograms.map.py
: This file houses functions for handling geographical aspects, such as map tiles and the geo-position of ships or stationary platforms.curtain.py
: This file contains functions related to 2.5D curtain.box.py
: This file contains functions related to obtaining and plotting box/polygon stream .hist.py
: This file contains functions related to histogram and statistical tables.utils.py
: This file contains configurations for plottings, such as width settings.Notes about this PR: https://docs.google.com/document/d/1QL89eLLcnLjhV8FRp4L_V1n52z0EbTwrrceGELBhVes/edit
Features built: https://github.com/OSOceanAcoustics/echoshader/issues/111 https://github.com/OSOceanAcoustics/echoshader/issues/112 https://github.com/OSOceanAcoustics/echoshader/issues/113 https://github.com/OSOceanAcoustics/echoshader/issues/117 https://github.com/OSOceanAcoustics/echoshader/issues/119 https://github.com/OSOceanAcoustics/echoshader/issues/115 https://github.com/OSOceanAcoustics/echoshader/issues/116 https://github.com/OSOceanAcoustics/echoshader/issues/86
small Issues solved: https://github.com/OSOceanAcoustics/echoshader/issues/107 https://github.com/OSOceanAcoustics/echoshader/issues/110 https://github.com/OSOceanAcoustics/echoshader/issues/99 https://github.com/OSOceanAcoustics/echoshader/issues/133 https://github.com/OSOceanAcoustics/echoshader/issues/132 https://github.com/OSOceanAcoustics/echoshader/issues/129 https://github.com/OSOceanAcoustics/echoshader/issues/127 https://github.com/OSOceanAcoustics/echoshader/issues/125 https://github.com/OSOceanAcoustics/echoshader/issues/96