OSOceanAcoustics / echoshader

Interactive visualization of ocean sonar data
https://echoshader.readthedocs.io
MIT License
9 stars 8 forks source link

Merge dev(version 0.1.0) into main #146

Closed ldr426 closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

ldr426 commented 1 year ago
  • Thanks @ldr426 I made a small PR Dev patch #147 with a few changes. Please check them and merge to dev, before merging to main.
  • I also noticed that the pictures in the echogram notebook of the box selection do not render in the read the docs version. Could you see if they will be ok?
Screenshot 2023-09-22 at 4 48 51 PM
  • The curtain plot does not show in the static notebook. Is there a way to make it display so people get an idea of how the plot looks like if they have not heard of "curtain".

@valentina-s Thanks for PR with the changes!

valentina-s commented 1 year ago

@ldr426 could you resolve the conflicts and we can merge into main. Then I will add a patch to reverse the axes so the echograms are plotted in the right orientation #108 .

valentina-s commented 1 year ago

This PR closes #144, #135, #120, #126, #106, #80.