search

OSS-Docs-Tools / code-owner-self-merge

A GitHub Action for letting CODEOWNERS merge PRs via green PR reviews
MIT License
53 stars 16 forks source link

Allow a codeowner to approve workflow run #26

Closed saschanaz closed 3 years ago

saschanaz commented 3 years ago

https://octokit.github.io/rest.js/v18#actions-approve-workflow-run

TypeScript-DOM-lib-generator does not allow PRs from first time contributors to run workflows and thus blocks code owner merging. Allowing codeowners to approve them would be great.

saschanaz commented 3 years ago

Wait, this requires write permission 😬

saschanaz commented 3 years ago

Ah, that should be okay, since it just uses GITHUB_TOKEN.

orta commented 3 years ago

For DT I built out a system to auto-allow it, IMO we could call this automatically if any PR is non-maintainer?

saschanaz commented 3 years ago

For DT I built out a system to auto-allow it, IMO we could call this automatically if any PR is non-maintainer?

In that case you can adjust the settings in Settings -> Actions rather than writing anything.

orta commented 3 years ago

TIL'd!

orta commented 3 years ago

I've changed this setting this for the DOM types repo, should be fine 👍🏻

saschanaz commented 3 years ago

Cool, will close this then.