Add support for "Full Name" in the Profile page - Githubissues

OSS-team-zulu / Zulu

Location-centric local discovery app. An open-source react-native app where users can pin points of interest on a shared map. Visibility is limited to nearby points of interest.

MIT License

8 stars 9 forks source link

Add support for "Full Name" in the Profile page #26

Closed nvgoldin closed 4 years ago

nvgoldin commented 4 years ago

"full_name" is supported by the Backend, but the ReactJS part doesn't send it, see this pic:

Adding support should be fairly trivial, follow these steps:

Modify the registration form component to include the new "Full Name" field:

https://github.com/OSS-team-zulu/Zulu/blob/4b39d0a6118d43c272ac0fa191b08233b7b8b675/frontend/zulu/src/components/Login/register.component.js#L39-L64

Add validation function vfullname and update the state/div where needed.
Make sure to update the AuthService.createUser to include it too: https://github.com/OSS-team-zulu/Zulu/blob/4b39d0a6118d43c272ac0fa191b08233b7b8b675/frontend/zulu/src/components/Login/register.component.js#L95-L98

Finally - test that you can register with fullname, and Profile works.

royackerman commented 4 years ago

Did it https://github.com/OSS-team-zulu/Zulu/pull/32/commits/6bf8d7eb3edad849ebb3edd3c89d8405a78b2972