search

OSSOS / MOP

The Moving Object Pipeline: discovery & tracking of trans-Neptunian objects
GNU General Public License v3.0
4 stars 9 forks source link

[track] SSOIS ephemeris error not handled cleanly #329

Closed mtbannister closed 10 years ago

mtbannister commented 10 years ago

On object L3TL, the return from SSOIS is incorrectly: Parsing query results...Image Ext X Y MJD Filter Exptime Object_RA Object_Dec Image_target Telescope_Insturment MetaData Datalink An error occured getting the ephemeris

which is instead caught as a ValueError: ValueError: not enough columns in table [ossos.ssos] File "/Users/michele/Dropbox/OSSOS/ossos-pipeline/src/ossos-pipeline/ossos/ssos.py", line 270, in parse table = table_reader.read(ssos_result_filename_or_lines) File "/Users/michele/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/astropy/io/ascii/core.py", line 818, in read str_vals = self.inconsistent_handler(str_vals, n_data_cols) File "/Users/michele/Dropbox/OSSOS/ossos-pipeline/src/ossos-pipeline/ossos/ssos.py", line 172, in _skip_missing_data raise ValueError("not enough columns in table")

instead of being raised as an error from SSOIS.

This object has a full set of images when queried through the web interface, so I am unsure what's creating the error in getting the ephemeris from SSOIS.

ijiraq commented 10 years ago

I was not able to reproduce this failure. Here is the procedure I followed:

vcp vos:OSSOS/measure3/2013B-L/13BL+3+0_p33.measure3.reals.astrom.L3TL.mpc L3TL.ast python validate.py track ./ -o ./ --debug

As a result I have create a track for this source while I will copy to VOSpace.

mtbannister commented 10 years ago

I tried again late yesterday and receive the same bug. Also occurs on the new H block objects' discovery triplets. Odd. Oh well.

ijiraq commented 10 years ago

This appears to be a problem with your install… since ‘it works for me’

JJ

On Aug 14, 2014, at 10:18 AM, Michele Bannister notifications@github.com wrote:

I tried again late yesterday and receive the same bug. Also occurs on the new H block objects' discovery triplets. Odd. Oh well.

mtbannister commented 10 years ago

Closing as won't fix, can't replicate. (My install is just special.)

ijiraq commented 10 years ago

well.. we should figure out what is actually causing the problem as you can’t do track if we don’t fix. On Aug 14, 2014, at 10:22 AM, Michele Bannister notifications@github.com wrote:

Closing as won't fix, can't replicate. (My install is just special.)

— Reply to this email directly or view it on GitHub.

mtbannister commented 10 years ago

I can track on the .ast files. Just have to have Brett update ossin.

mtbannister commented 10 years ago

I have edc762c29641c0cb8572fae7ce3c2de811239293 as my current version and am still getting the error. It now occurs on all .ast files as well (so I can't run track) so clearly there is something install-related going on.

What version of astropy are you running? Trying to think what it could be.

mtbannister commented 10 years ago

Closed by de601c1fb2497084987dc73dccecc86574778f13 . Oops for unpushed commits.