jmpetit
commented
10 years ago Hi there,
from the names of the first 2 scripts, I'd say they do very similar but somehow opposite things. Clearly the first one find the match between combined candidates and implanted list, while the second one does the same, just to select those that were not implanted, and hence are false positives, as it's applied to the scrambled set.
Maybe the third one does the work of the 2 first ones, which would explain it's twice the size (not a good reason actually).
My 2 cents, cheers, Jean-Marc
On Fri, 26 Sep 2014, Michele Bannister wrote:
In scripts/, there are three scripts that seem to perform identical functions, measuring the match between the original and the planted source lists: scripts/astrom_check.py scripts/false_positives_mags.py scripts/validate_checker.py
Of these, validate_checker is the most recent and is more than twice the size of the other two. All three duplicate code to some extent.
Can we proceed with deletion of astrom_check.py and false_positives_mags.py?
Reply to this email directly or view it on GitHub: https://github.com/OSSOS/MOP/issues/333
[ Jean-Marc Petit ] [ ----- ] [ Institut UTINAM - UMR CNRS 6213 * tel: (33) [0]381 666 929 .../ ] [ Observatoire de Besancon * fax: (33) [0]381 666 944 ./ ] [ 41 bis Avenue de l'Observatoire * email: /.\ ] [ BP 1615 * petit_at_obs-besancon.fr / . \ ] [ F-25010 Besancon cedex * ----- ]
mtbannister
In scripts/, there are three scripts that seem to perform identical functions, measuring the match between the original and the planted source lists: scripts/astrom_check.py scripts/false_positives_mags.py scripts/validate_checker.py
Of these, validate_checker is the most recent and is more than twice the size of the other two. All three duplicate code to some extent.
Can we proceed with deletion of astrom_check.py and false_positives_mags.py?