OSSPhilippines / freefolio

100% FREE professional portfolio website templates
https://freefolio.web.app
MIT License
211 stars 60 forks source link

Add animation on scroll to template sites #79

Closed fidellim closed 1 year ago

fidellim commented 1 year ago

Reference of the issue: https://github.com/OSSPhilippines/freefolio/issues/78 resolve https://github.com/OSSPhilippines/freefolio/issues/78

Click to view changes #### Part 1 https://user-images.githubusercontent.com/26820513/227697973-8a6dbb9b-f11c-4bb5-8fdd-e2808a1eb043.mp4 #### Part 2 https://user-images.githubusercontent.com/26820513/227697974-4f41159c-8833-4abe-91e7-b3318a3520e8.mp4 #### Part 3 https://user-images.githubusercontent.com/26820513/227697977-c566db28-09bc-4923-9301-9c5cccd46216.mp4 #### Part 4 https://user-images.githubusercontent.com/26820513/227697978-543b49e2-0637-4336-9910-9f2888d401d5.mp4
github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit e022351):

https://freefolio--pull-requests-g4fxrupu.web.app

(expires Sat, 01 Apr 2023 05:23:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0970846dd0fc53318864266da8ba6cc9470d08c7

fidellim commented 1 year ago

Hello! Just have a question. If the issue has been resolved, who will be the one to close it? Is it the one who posted the issue or the maintainer of the project?

jofftiquez commented 1 year ago

Hello! Just have a question. If the issue has been resolved, who will be the one to close it? Is it the one who posted the issue or the maintainer of the project?

Hello you may reference the issues to the PR so that GitHub can close it automatically on PR closed event.

Thank you for this PR!

fidellim commented 1 year ago

Hello! Just have a question. If the issue has been resolved, who will be the one to close it? Is it the one who posted the issue or the maintainer of the project?

Hello you may reference the issues to the PR so that GitHub can close it automatically on PR closed event.

Thank you for this PR!

Hello, I would just like to confirm if this is the way to reference it? Click link here.

jofftiquez commented 1 year ago

Hello, I would just like to confirm if this is the way to reference it? Click link here.

Yes that is correct.

E.g.Closes #80 Resolves #12 etc.

fidellim commented 1 year ago

Hello, I would just like to confirm if this is the way to reference it? Click link here.

Yes that is correct.

E.g.Closes #80 Resolves #12 etc.

Thanks sir @jofftiquez.