OSSPhilippines / freefolio

100% FREE professional portfolio website templates
https://freefolio.web.app
MIT License
204 stars 59 forks source link

Add OG Tags #80

Closed fidellim closed 1 year ago

fidellim commented 1 year ago

Used OG image of this site but as the size of 1200x630.

Resolves #58 . Only added OG Tags to root page.

It should look something like this (can't test it with the OG image of this site yet as the image is not yet deployed to the specified absolute path:):

Absolute path of og image: https://freefolio.web.app/images/oss_ph_org.png

Click to view supposed change ![Screenshot 2023-03-25 113254](https://user-images.githubusercontent.com/26820513/227706929-67a5189e-1a08-4f8c-a895-0c8a315cacc9.png)
github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 0aaff26):

https://freefolio--pull-requests-g4fxrupu.web.app

(expires Sat, 01 Apr 2023 08:47:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0970846dd0fc53318864266da8ba6cc9470d08c7

fidellim commented 1 year ago

Hello sir @jofftiquez, upon checking, the OG Tag has not been updated yet. Not sure why the image can't be accessed although I have saved the image inside the /images folder

Click to view error

![image](https://user-images.githubusercontent.com/26820513/227908187-7f3dc0d4-6964-4338-ad7b-90fdb66486e0.png)

I am thinking of renaming the file as "oss-ph-og.png" instead. Maybe that can fix the issue.

fidellim commented 1 year ago

sir @jofftiquez, this is the outcome I am aiming for,

Facebook OG

Click to view

![image](https://user-images.githubusercontent.com/26820513/227911204-4e0c31cc-d52e-4e8a-823f-130b6a7dc36c.png)

Twitter OG

Click to view

![image](https://user-images.githubusercontent.com/26820513/227911249-9b770734-5b44-47b2-88c8-a1fddcd93310.png)

jofftiquez commented 1 year ago

Hi @fidellim thanks for reporting. I will check as well. Altho as long as it's static there should be no issue here, I wonder what's wrong. Will keep you posted.