search

OSSPhilippines / philippines-travel-level-map

A simple web app that visualizes how well-travelled you are in the Philippines
https://my-philippines-travel-level.com
GNU General Public License v3.0
129 stars 44 forks source link

metro manila version #10

Open benbancure94 opened 1 year ago

benbancure94 commented 1 year ago

Good day!

I created my own version, but only for Metro Manila. This is not yet pushed into this repo.

phMap (6)

warengonzaga commented 1 year ago

Amazing work @benbancure94 do you have the repo? or you want to add this as feature to the project?

benbancure94 commented 1 year ago

I downloaded a clone of this repository and modified in my local computer.

warengonzaga commented 1 year ago

Cool, do you have plans to release it to the public or you want to add that as new feature for the project?

benbancure94 commented 1 year ago

Would you mind that I will release/deploy this to public myself but using the cloned code from your project?

warengonzaga commented 1 year ago

Hmm, if you want to release it, feel free but please add credits to your readme linking back to this repository.

benbancure94 commented 1 year ago

Ok, sure .

loumexx commented 1 year ago

This is awesome! I'm actually also making my own, pretty much serving as coding practice. Looking forward to when this gets released!

benbancure94 commented 1 year ago

Here is mine.

jofftiquez commented 1 year ago

Here is mine.

Great work! Do you have plans on making a PR for this to the main repo?

warengonzaga commented 1 year ago

same question @benbancure94 maybe we can add this to the main project.

denzdelvillar commented 1 year ago

I think our options are:

a) we can put a section Have You Tried: that lists down links to all other maps like @benbancure94's that was inspired by this project, or b) integrate the new maps into the main project itself

I'm more inclined towards option a because it gives the other developers more freedom with their own maps without having to do a PR on this project when they change something.

jofftiquez commented 1 year ago

I think our options are:

a) we can put a section Have You Tried: that lists down links to all other maps like @benbancure94's that was inspired by this project, or b) integrate the new maps into the main project itself

I'm more inclined towards option a because it gives the other developers more freedom with their own maps without having to do a PR on this project when they change something.

I agree. Our goal to highlight all projects as much as possible while maintaining collaboration at the same time. Kudos to you guys. It's still up to @benbancure94 let us know what you think.

Speaking of option a, @denzdelvillar maybe we can start updating the design of the about page? As suggested in https://github.com/OSSPhilippines/philippines-travel-level-map/issues/15 we need to put the map itself first, then additional details in other pages. For the idea of option a we can add a toolbar to the / page.

warengonzaga commented 1 year ago

We can add a menu in the main web app for other versions, what do you folks think?

warengonzaga commented 1 year ago

Are we still going to add this? I think we can look back at this again sometime in the future.