OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
185 stars 194 forks source link

chromium: Reduce minimum browser window width to 480px #698

Open marex opened 1 year ago

marex commented 1 year ago

The TST043015CNHX panel is a 480x272 panel. Chromium browser limits the minimum window width to 500px since commits:

6b0ecc1e4532c ("Set lower bound on contents pane size.")

580d6900dc7fc ("In tab dragging, the window size should be larger than its minimum size.")

To make chromium browser usable on those tiny panels as well, reduce the minimum window width to 480px. The upstreaming of this change is in progress.

rakuco commented 1 year ago

The upstreaming of this change is in progress.

Is there a CL in Gerrit or an upstream bug report you can refer to? I'm weary of taking this patch in without more information, as the new size also looks somewhat arbitrary from a meta-chromium perspective.

marex commented 1 year ago

The upstreaming of this change is in progress.

Is there a CL in Gerrit or an upstream bug report you can refer to? I'm weary of taking this patch in without more information, as the new size also looks somewhat arbitrary from a meta-chromium perspective.

@rakuco I sent the patch to the authors of the aforementioned two commits via email as the chromium contribution guidelines are difficult for such a one-liner . I cannot tell whether they created a crbug from that, sorry, but this one https://bugs.chromium.org/p/chromium/issues/detail?id=875197 is very much the same issue (and probably any other crbug which mentions "500px" in some width context)

otavio commented 1 year ago

I support the addition of a workaround for this, but we need a long-term vision to remove the workaround. @rakuco, can you fix this upstream?

marex commented 1 year ago

@otavio @rakuco has there been any progress ? The patch still applies to latest chromium version too.

otavio commented 1 year ago

I support adding this patch. @rakuco ?