Closed nrpt-m closed 1 year ago
Thanks @nrpt-m !
is it x32 we are talking about or 32bit x86 here ?
is it x32 we are talking about or 32bit x86 here ?
It's about 32bit x86 target
Interesting change. 32-bit Linux hasn't been officially supported by Google Chrome for quite a while (see e.g. https://groups.google.com/a/chromium.org/g/chromium-packagers/c/Q7jI7kI9umM/m/IoPYldUSCwAJ and https://support.google.com/chrome/a/answer/7100626) so I'm actually surprised this didn't break before.
Could you mention the error you're getting as well as the links above in the commit/PR message?
Done.
Looks good now. I just noticed one thing: can you use "chromium" instead of "chromium-x11" in the commit/PR? This change also affects the chromium-ozone-wayland build since it's in
chromium-gn.inc
that is shared by both recipes.
Done.
The x86-32 bit target build is not supported for Chromium-x11 so do_configure fails while building x86-32 bit target but, the failure appears quite late in a build.
Removing x86-32 bit target from COMPATIBLE_MACHINE will make it fail much earlier and in clear manner if a user tries to build for an x86-32 bit target.
References: https://groups.google.com/a/chromium.org/g/chromium-packagers/c/Q7jI7kI9umM/m/IoPYldUSCwAJ https://support.google.com/chrome/a/answer/7100626
Error logs while building x86-32 bit target: