search

OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
185 stars 194 forks source link

chromium: Indicate that x86-32 is not a supported machine #703

Closed nrpt-m closed 1 year ago

nrpt-m commented 1 year ago

The x86-32 bit target build is not supported for Chromium-x11 so do_configure fails while building x86-32 bit target but, the failure appears quite late in a build.

Removing x86-32 bit target from COMPATIBLE_MACHINE will make it fail much earlier and in clear manner if a user tries to build for an x86-32 bit target.

References: https://groups.google.com/a/chromium.org/g/chromium-packagers/c/Q7jI7kI9umM/m/IoPYldUSCwAJ https://support.google.com/chrome/a/answer/7100626

Error logs while building x86-32 bit target:

| DEBUG: Python function extend_recipe_sysroot finished | DEBUG: Executing shell function do_configure | ERROR at //BUILD.gn:1641:1: Assertion failed. | assert( | ^----- | 'target_cpu=x86' is not supported for 'target_os=linux'. Consider omitting 'target_cpu' (default) or using 'target_cpu=x64' instead. | See //BUILD.gn:1642:5: | is_valid_x86_target || target_cpu != "x86" || v8_target_cpu == "arm", | ^------------------------------------------------------------------- | This is where it was set. | WARNING: /buildarea/eng1/chromium/poky/build/tmp/work/core2-32-poky-linux/chromium-x11/111.0.5563.64-r0/temp/run.do_configure.456546:149 exit 1

rwmacleod commented 1 year ago

Thanks @nrpt-m !

kraj commented 1 year ago

is it x32 we are talking about or 32bit x86 here ?

nrpt-m commented 1 year ago

is it x32 we are talking about or 32bit x86 here ?

It's about 32bit x86 target

nrpt-m commented 1 year ago

Interesting change. 32-bit Linux hasn't been officially supported by Google Chrome for quite a while (see e.g. https://groups.google.com/a/chromium.org/g/chromium-packagers/c/Q7jI7kI9umM/m/IoPYldUSCwAJ and https://support.google.com/chrome/a/answer/7100626) so I'm actually surprised this didn't break before.

Could you mention the error you're getting as well as the links above in the commit/PR message?

Done.

nrpt-m commented 1 year ago

Looks good now. I just noticed one thing: can you use "chromium" instead of "chromium-x11" in the commit/PR? This change also affects the chromium-ozone-wayland build since it's in chromium-gn.inc that is shared by both recipes.

Done.