search

OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
185 stars 194 forks source link

chromium: Update to 113.0.5672.* #710

Closed rwmacleod closed 1 year ago

rwmacleod commented 1 year ago

Just as we are close to finishing 112, along comes 113! https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop.html

MaxIhlenfeldt commented 1 year ago

If no one else wants to take this, I can tackle this next week.

nrpt-m commented 1 year ago

@MaxIhlenfeldt, I am looking forward to your chromium-113 update and will test it once PR is available. Let us know, if there are any problems.

MaxIhlenfeldt commented 1 year ago

dunfell using clang 12 is once again causing problems. Would it be possible to take the same approach for using clang 14 as we took for using Node 14? I fear we else might continue to need one or two dunfell-specific patches every new version...

kraj commented 1 year ago

it will be some effort but I think using same compiler as kirkstone on dunfell might be something doable but it will need some work and testing, because when we use newer clang system-wide then many packages may not compile with it.

MaxIhlenfeldt commented 1 year ago

I see, makes sense. I'll continue to try and make it work with clang 12, then, and we can look into using clang 14 separately in #716.

rwmacleod commented 1 year ago

@MaxIhlenfeldt are you waiting to be able to use clang-14 on dunfell or should we try to fix the compile issues with clang-12?

If you send a PR, @nrpt-m and I could test it and perhaps help fix any compilation issues.

MaxIhlenfeldt commented 1 year ago

I'm still working on this. I now have something that compiles on kirkstone and langdale, dunfell still needs some work. Not sure if it makes sense to upload the WIP update, as changes to the patches or entirely new ones would probably mean we'd need to test the non-dunfell configurations again, right?

rwmacleod commented 1 year ago

I'm still working on this. I now have something that compiles on kirkstone and langdale, dunfell still needs some work. Not sure if it makes sense to upload the WIP update, as changes to the patches or entirely new ones would probably mean we'd need to test the non-dunfell configurations again, right?

Sure, if you are making progress, we'll just wait to test.

If you want some input on the compilation problems, we can spend time on that if you are stuck.

MaxIhlenfeldt commented 1 year ago

If you want some input on the compilation problems, we can spend time on that if you are stuck.

Thanks! I think I now have everything patched that needs patching. Luckily, it's mostly just backports. I'll upload everything on Monday!

MaxIhlenfeldt commented 1 year ago

PR is up at #721!