chromium: Update to 114.0.5735.*

[MaxIhlenfeldt]

Once again, 114 is out before we have finished updating to 113.

I can start this update as soon as we're done with 113, which should hopefully be soon.

[MaxIhlenfeldt]

Now that the update to 113 is done, I'll start working on this tomorrow!

[rwmacleod]

Thanks @MaxIhlenfeldt Hopefully this update will be a bit easier and therefore faster. It looks like 114.0.5735.106 is the latest: https://chromereleases.googleblog.com/search/label/Stable%20updates It also fixes a critical CVE so people will be happy to see this work out soon. Our build servers are warming up ! ;-)

[MaxIhlenfeldt]

It seems I have the build working for mickledore, and if we're lucky, the current build will be the first one to work for kirkstone as well.

However, I started getting the weird use of undeclared identifier '__ops'; did you mean '__gnu_cxx::__ops'? errors on dunfell again that I already mentioned here before when working on 112.

Not sure why it reappeared again, it was gone when I was working on 113. As it seems this is a local problem (no one else saw this for 112), I'll just upload the patch if that's the only remaining issue. Of course, there may still be other errors on dunfell that I'm unable to see as this one happens relatively early in the build, if that's the case you'd have to relay these errors to me so I can fix them :sweat_smile:

[MaxIhlenfeldt]

Hm, I can reproduce the dunfell error on another machine. I'll try one more build on a third machine that's using a different distro than the other two.

@kraj I think we started looking into this during the m112 update (see comments after this one, but never got anywhere as I didn't have time and it didn't reappear until know. I'd appreciate any ideas you might have :smile:

[MaxIhlenfeldt]

The third machine gives me an error when trying to compile nodejs-native, now I'm properly confused... I feel like I'm missing something obvious.

| In file included from ../deps/v8/src/base/macros.h:12,
|                  from ../deps/v8/src/libplatform/worker-thread.h:12,
|                  from ../deps/v8/src/libplatform/worker-thread.cc:5:
| ../deps/v8/src/base/logging.h: In function ‘typename std::enable_if<(std::is_enum<_Tp>::value && (! v8::base::has_output_operator<T>::value)), std::__cxx11::basic_string<char> >::type v8::base::PrintCheckOperand(T)’:
| ../deps/v8/src/base/logging.h:170:34: error: ‘uint8_t’ was not declared in this scope
|   170 |       std::is_same<underlying_t, uint8_t>::value, uint16_t,
|       |                                  ^~~~~~~
| ../deps/v8/src/base/logging.h:16:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
|    15 | #include "src/base/template-utils.h"
|   +++ |+#include <cstdint>
|    16 |
| ../deps/v8/src/base/logging.h:170:41: error: template argument 2 is invalid
|   170 |       std::is_same<underlying_t, uint8_t>::value, uint16_t,
|       |                                         ^
| ../deps/v8/src/base/logging.h:170:51: error: ‘uint16_t’ was not declared in this scope
|   170 |       std::is_same<underlying_t, uint8_t>::value, uint16_t,
|       |                                                   ^~~~~~~~
| ../deps/v8/src/base/logging.h:170:51: note: ‘uint16_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
| ../deps/v8/src/base/logging.h:172:61: error: template argument 1 is invalid
|   172 |                                 int16_t, underlying_t>::type>::type;
|       |                                                             ^
| ../deps/v8/src/base/logging.h:172:61: error: template argument 2 is invalid
| ../deps/v8/src/base/logging.h:172:62: error: ‘<declaration error>’ is not a template [-fpermissive]
|   172 |                                 int16_t, underlying_t>::type>::type;
|       |                                                              ^~
| ../deps/v8/src/base/logging.h:173:40: error: ‘int_t’ does not name a type; did you mean ‘wint_t’?
|   173 |   return PrintCheckOperand(static_cast<int_t>(static_cast<underlying_t>(val)));
|       |                                        ^~~~~
|       |                                        wint_t
| ../deps/v8/src/base/macros.h: At global scope:
| ../deps/v8/src/base/macros.h:338:25: error: ‘intptr_t’ has not been declared
|   338 | inline T RoundDown(T x, intptr_t m) {
|       |                         ^~~~~~~~
| ../deps/v8/src/base/macros.h:344:11: error: ‘intptr_t’ has not been declared
|   344 | template <intptr_t m, typename T>
|       |           ^~~~~~~~
| ../deps/v8/src/base/macros.h: In function ‘constexpr T RoundDown(T)’:
| ../deps/v8/src/base/macros.h:348:17: error: ‘m’ was not declared in this scope
|   348 |   STATIC_ASSERT(m != 0 && ((m & (m - 1)) == 0));
|       |                 ^
| ../deps/v8/src/base/macros.h:200:43: note: in definition of macro ‘STATIC_ASSERT’
|   200 | #define STATIC_ASSERT(test) static_assert(test, #test)
|       |                                           ^~~~
| ../deps/v8/src/base/macros.h: At global scope:
| ../deps/v8/src/base/macros.h:354:23: error: ‘intptr_t’ has not been declared
|   354 | inline T RoundUp(T x, intptr_t m) {
|       |                       ^~~~~~~~
| ../deps/v8/src/base/macros.h:358:11: error: ‘intptr_t’ has not been declared
|   358 | template <intptr_t m, typename T>
|       |           ^~~~~~~~
| ../deps/v8/src/base/macros.h: In function ‘constexpr T RoundUp(T)’:
| ../deps/v8/src/base/macros.h:361:20: error: ‘m’ was not declared in this scope
|   361 |   return RoundDown<m, T>(static_cast<T>(x + (m - 1)));
|       |                    ^
| ../deps/v8/src/base/macros.h: In function ‘void* AlignedAddress(void*, size_t)’:
| ../deps/v8/src/base/macros.h:372:51: error: ‘uintptr_t’ does not name a type
|   372 |   return reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(address) &
|       |                                                   ^~~~~~~~~
| ../deps/v8/src/base/macros.h:13:1: note: ‘uintptr_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
|    12 | #include "src/base/logging.h"
|   +++ |+#include <cstdint>
|    13 |
| ../deps/v8/src/base/macros.h:373:47: error: ‘uintptr_t’ does not name a type
|   373 |                                  ~static_cast<uintptr_t>(alignment - 1));
|       |                                               ^~~~~~~~~
| ../deps/v8/src/base/macros.h:373:47: note: ‘uintptr_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
| make[1]: *** [tools/v8_gypfiles/v8_libplatform.host.mk:141: Release/obj.host/v8_libplatform/deps/v8/src/libplatform/worker-thread.o] Error 1
| make[1]: *** Waiting for unfinished jobs....
| rm 8b3b2cb62dd5a9def6a15d6383c1cddc1a3b41ba.intermediate e298d3cd23bbacb6ce34122a582812189aff6dec.intermediate
| make: *** [Makefile:109: node] Error 2
| ERROR: oe_runmake failed
| WARNING: /home/igalia/yocto-chromium/builds/ci-chromium-x11-rpi4-dunfell/tmp-glibc/work/x86_64-linux/nodejs-native/14.18.1-r0/temp/run.do_compile.948427:1 exit 1 from 'exit 1'
| ERROR: Execution of '/home/igalia/yocto-chromium/builds/ci-chromium-x11-rpi4-dunfell/tmp-glibc/work/x86_64-linux/nodejs-native/14.18.1-r0/temp/run.do_compile.948427' failed with exit code 1
ERROR: Task (virtual:native:/home/igalia/yocto-chromium/sources/meta-openembedded/meta-oe/recipes-devtools/nodejs/nodejs_14.18.1.bb:do_compile) failed with exit code '1'

[russdill]

Note that enabling use_v4l2_codec=true requires linux-libc-headers >= 6.1 (not yet available in kirkstone and older)

[MaxIhlenfeldt]

Was there a change related to this in 114? It seems to me that the default is use_v4l2_codec=false for non-Lacros platforms [1].

[1] https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/args.gni;l=21-22;drc=1fe3ac087197f01f95332f9cd9eab25fa6b20b09

[russdill]

Yes, the default is false. Just a note for those trying to build with true. For reference https://source.chromium.org/chromium/chromium/src/+/2a8f8a7b357b895108598ebee922c3a5fb877072 in 101.0.4933.0 introduced a requirement for v5.17 and https://source.chromium.org/chromium/chromium/src/+/a5c4a9aeb274b02f9caaf71ff3c3eed30bc8dc91 in 114.0.5720.0 introduced a requirement for v6.1

[MaxIhlenfeldt]

Ok, thanks for the heads up!