search

OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
183 stars 189 forks source link

Track additional Wayland seats #728

Open Lachlan-Frawley opened 1 year ago

Lachlan-Frawley commented 1 year ago

This allows chromium-ozone-wayland to track more than one seat. In turn, this lets VNC/RDP pass keyboard and mouse inputs to chromium.

lukasz-czechowski commented 2 months ago

Hi, the issue with missing inputs in VNC/RDP sessions still seem to be the case (meta-browser master branch as for 06.2024). What is the status of this patch?

Lachlan-Frawley commented 2 months ago

Honestly I completely forgot about this. I haven't attempted to upstream the patch and probably will never try. If there is interest I will rebase this patch onto the current master, although I strongly suspect the actual patch itself still works fine and could probably be added to existing projects with a bbappend.

lukasz-czechowski commented 2 months ago

Can we at least merge it into master? I've verified that the patch itself works, but some issues still remain (in particular, the pointer is not visible) - I can provide fixes for those, but they depend on the original patch.

Lachlan-Frawley commented 2 months ago

I have yet to test my rebase of the patch, but I've pushed it to my fork for now anyway. I'll make sure to test this locally on my imx8 system at least and comment on the results when I'm done.

Lachlan-Frawley commented 2 months ago

I've finally managed to get VNC working on my imx8 device and verified the patch works as expected. What steps need to be taken to get this merged?

Also interestingly enough, I can see the cursor.

MaxIhlenfeldt commented 2 months ago

To be honest, I'd prefer this patch to be upstream, I think the chances of it being accepted are very high. If you upload a CL (instructions) I can send it to the right reviewer and take care of all the other organizational stuff :)

Lachlan-Frawley commented 2 months ago

Sure, I'll try to get to that soon when I have some time.

Lachlan-Frawley commented 1 month ago

I've submitted the work here: https://chromium-review.googlesource.com/c/chromium/src/+/5652465

lukasz-czechowski commented 1 month ago

I've finally managed to get VNC working on my imx8 device and verified the patch works as expected. What steps need to be taken to get this merged?

Also interestingly enough, I can see the cursor.

Thanks! As for missing cursor, I'm observing this on my setup that uses Weston compositor. I found that assigning a cursor in void WaylandConnection::UpdateCursor() in wayland_connection.cc solves the problem.

Lachlan-Frawley commented 1 month ago

Interesting, I'm also using Weston. I'm using Scarthgap for my test distribution. What about you?

(I'm also using a Toradex im8qm as my test platform)