Closed russdill closed 1 year ago
Thanks for the patch. @MaxIhlenfeldt can you take a look at this one with your upstream hat?
Sure! Thanks for catching this.
I don't think connection_
can be NULL here, could you please confirm that adding only if (connection_->window_drag_controller())
is enough to fix the crash? Then I can upstream the change.
Verified that removing the check for connection_ being NULL does not break the fix.
Thank you! Upstream review is live at https://crrev.com/c/4724882.
Relaying a comment from the reviewer: @russdill
I'd like to understand it a bit more: is it the seat or the data_device_manager that isn't available in the aforementioned environment?
I'm sorry, I don't know the answer to those questions. I just know we have two weston instances running, and one of them doesn't have any input devices associated with it.
The patch has been merged upstream, thanks again! I'll upload a PR with a backport tomorrow.
A recent change within ui/ozone/platform/wayland/host/wayland_window_manager.cc, 5ae87c3476 "fixup! [ozone/wayland] Harden the logic that chooses the window being dragged" causes a crash if no input devices are available.