OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
183 stars 189 forks source link

chromium-gn.inc: make alsa configurable #751

Closed vermaete closed 11 months ago

vermaete commented 11 months ago

based on the DISTRO_FEATURE alsa

rakuco commented 11 months ago

The patch looks sensible, but I'd like to confirm one thing: does a lack of "alsa" in DISTRO_FEATURES mean the target system has no sound or something like that, or is the idea to use a different backend?

vermaete commented 11 months ago

Hi,

It was just a matter of having my image slightly smaller for my product without a need for sound.

Br,

Op ma 11 sep. 2023 om 09:16 schreef Raphael Kubo da Costa < @.***>

The patch looks sensible, but I'd like to confirm one thing: does a lack of "alsa" in DISTRO_FEATURES mean the target system has no sound or something like that, or is the idea to use a different backend?

— Reply to this email directly, view it on GitHub https://github.com/OSSystems/meta-browser/pull/751#issuecomment-1713303805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5IFKSC3L3FFCB7UVQTP4TXZ23E3ANCNFSM6AAAAAA4RUDXCY . You are receiving this because you authored the thread.Message ID: @.***>

rakuco commented 11 months ago

Got it, thanks. Since the DISTRO_FEATURE entry is already there, I think it doesn't hurt to do this.