search

OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
183 stars 189 forks source link

chromium: update to 119.0.6045.159 #771

Closed MaxIhlenfeldt closed 9 months ago

MaxIhlenfeldt commented 9 months ago

Release notes: https://chromereleases.googleblog.com/2023/10/stable-channel-update-for-desktop_31.html https://chromereleases.googleblog.com/2023/11/stable-channel-update-for-desktop.html https://chromereleases.googleblog.com/2023/11/stable-channel-update-for-desktop_14.html

Build and patch changes:

Drop five backported patches that are included upstream now, and add four new backports.

Add more fixes to 0017-Avoid-parenthesized-initialization-of-aggregates.patch.

Add 0021-Don-t-delete-CrashKeyWithName-dtor.patch to fix a build error on older versions of clang (on mickledore, kirkstone, and dunfell).

Rebase remaining patches.

License changes:

Added licenses:

Removed licenses:

Updated licenses: none.

Test-built (big thanks to @nrpt-m):

** Please note that Chromium requires below set-up when on dunfell branch.

*** Please note that there currently is a problem on RPi4/dunfell where Chromium crashes because of an illegal instruction error.

Signed-off-by: Max Ihlenfeldt max@igalia.com

MaxIhlenfeldt commented 9 months ago

@nrpt-m as always, testing would be greatly appreciated! Like in the last PR, I already included the test results in the changelog's "Test-built" section. I'll check again that it's correct once the testing is finished.

nrpt-m commented 9 months ago

@MaxIhlenfeldt @rakuco, While building chromium-119 in master branch, do_configure task failed for all the machines. Please find the attached logs. chromium-119-do_configure_failed.txt

MaxIhlenfeldt commented 9 months ago

This should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/5001687. Give me a moment to create a backport.

MaxIhlenfeldt commented 9 months ago

@nrpt-m please try again with the latest revision.

nrpt-m commented 9 months ago

@nrpt-m please try again with the latest revision.

Thanks, it started compiling now ;-)

kraj commented 9 months ago

I have built and run it on musl system 

chromium-ozone-wayland:
master, clang, musl, MACHINE=qemux86-64
nrpt-m commented 9 months ago

@MaxIhlenfeldt @rakuco , Have completed the builds & testing in master branch for all these below systems and chromium worked well in all these systems.

qemuarm* :- Have again observed same messages as with 118 on console while running chromium but, chromium works fine.

[ 203.896427] Alignment trap: chromium-bin (858) PC=0x07e6e40e Instr=0xe950a301 Address=0x57378592 FSR 0x221 [ 203.896763] Alignment trap: chromium-bin (858) PC=0x07e6e40e Instr=0xe950a301 Address=0x5737859a FSR 0x221 [ 203.897181] Alignment trap: chromium-bin (858) PC=0x07e6e40e Instr=0xe950a301 Address=0x573785a2 FSR 0x221 [ 203.897601] Alignment trap: chromium-bin (858) PC=0x07e6e40e Instr=0xe950a301 Address=0x573785aa FSR 0x221 [ 203.898061] Alignment trap: chromium-bin (858) PC=0x07e6e40e Instr=0xe950a301 Address=0x573785b2 FSR 0x221 [ 203.898723] Alignment trap: chromium-bin (858) PC=0x07e6e40e Instr=0xe950a301 Address=0x573785ba FSR 0x221 root@qemuarm:~#

raspberrypi4-64* :- Chromium works fine but, @rwmacleod has observed that while running youtube in chromium audio is not coming. Let us know your thought on this as Audio used to work before.

nrpt-m commented 9 months ago

@MaxIhlenfeldt @rakuco, Have completed the builds & testing in kirkstone branch for all these below systems and chromium worked well in all these systems.

Next is dunfell and mickledore branches.

nrpt-m commented 9 months ago

@MaxIhlenfeldt @rakuco Have completed the builds & testing in mickledore branch for all these below systems and chromium worked well in all these systems.

raspberrypi4-64**:- Chromium works fine but, @rwmacleod has observed that while running youtube in chromium audio is not coming same as with master branch. Have attached the logs. Chromium-119-rpi4-mickledore.log

MaxIhlenfeldt commented 9 months ago

From the log:

XDG_RUNTIME_DIR (/tmp) is not owned by us (uid 1000), but by uid 0! (This could e.g. happen if you try to connect to a non-root PulseAudio as a root user, over the native protocol. Don't do that.)
ALSA lib /usr/src/debug/alsa-plugins/1.2.7.1-r0/pulse/pulse.c:242:(pulse_connect) PulseAudio: Unable to connect: Connection refused

Sounds to me like this is caused by something else, and not Chromium, could that be?

nrpt-m commented 9 months ago

Sounds to me like this is caused by something else, and not Chromium, could that be?

May be but, it used to work earlier as @rwmacleod said.

nrpt-m commented 9 months ago

@MaxIhlenfeldt @rakuco Have completed the builds & testing in dunfell branch for all these below systems and chromium worked well in all these systems.

raspberrypi4-64**:- Have observed again the illegal instruction error with chromium-119 as well. Have attached the console logs. chromium-119-rpi4-dunfell-console-logs.txt

Coredump file at: https://tempsend.com/gxmzu Chromium-bin file at: https://tempsend.com/grcuz

marex commented 9 months ago

It seems since about v110, the GPU process crashes with error 5 on MX8M with etnaviv driver and weston compositor, and Chromium works only with software rendering.

rwmacleod commented 9 months ago

Sounds to me like this is caused by something else, and not Chromium, could that be?

May be but, it used to work earlier as @rwmacleod said.

I suspect that audio will work with the XFCE desktop as a non root user. @nrpt-m said that he'd check when testing this update with WR Linux once 119 is merged if no one gets there earlier.

MaxIhlenfeldt commented 9 months ago

Thanks for the testing! I'll merge this now, and then @nrpt-m can verify audio (hopefully) still works and we can take a closer look at the illegal instruction error.

@marex please look through the existing issues if this is already known (#711 sounds like it might be related?), and if not file a new issue, as this isn't related to this PR.

nrpt-m commented 9 months ago

Thanks for the testing! I'll merge this now, and then @nrpt-m can verify audio (hopefully) still works and we can take a closer look at the illegal instruction error.

@MaxIhlenfeldt , We have verified the audio while running youtube in chromium with rpi4/mickledore WR Linux image and it works fine.

nrpt-m commented 9 months ago

@MaxIhlenfeldt @rakuco Have completed the builds & testing in dunfell branch for all these below systems and chromium worked well in all these systems.

  • chromium-ozone-wayland: qemux86-64
  • chromium-x11: qemux86-64, qemuarm, qemuarm64, raspberrypi4-64**

raspberrypi4-64**:- Have observed again the illegal instruction error with chromium-119 as well. Have attached the console logs. chromium-119-rpi4-dunfell-console-logs.txt

Coredump file at: https://tempsend.com/gxmzu Chromium-bin file at: https://tempsend.com/grcuz

@MaxIhlenfeldt , Could you please check these details about illegal instruction error.

marex commented 8 months ago

@marex please look through the existing issues if this is already known (#711 sounds like it might be related?), and if not file a new issue, as this isn't related to this PR.

@MaxIhlenfeldt right, #711 was open for some 10 releases now and it seems there is no fix ? Is there any interest in fixing that problem ?

TheNathan0 commented 8 months ago

Last I checked surrounding #711, using Google's Wayland fork supposedly should've fixed this but from my experience, it only resulted in a different error that I never looked further into. I'm no expert at this so I hadn't looked much into it ever since I had failed to get Chromium starting with full GPU acceleration (by means of using flags: --in-process-gpu and --use-gl=egl).

It seems like the x86-64 Arch Linux folks have achieved full GPU acceleration + native EGL (no ANGLE abstraction layer) + native Ozone Wayland working on Chromium with Google's Wayland fork (See: https://aur.archlinux.org/packages/chromium-wayland-vaapi) and some patching. I'm not sure if this is going to help much, but I figured I'd put it just here in case someone interested might need it to figure out how to fix #711. I'm going to assume that X11 is unaffected?

MaxIhlenfeldt commented 8 months ago

@MaxIhlenfeldt right, #711 was open for some 10 releases now and it seems there is no fix ? Is there any interest in fixing that problem ?

I don't have that hardware and so can't do much about the issue, not sure if anyone else can work on it. Please use that issue to further discuss it instead of this PR.